Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix: some typos in documentation and comments #1433

Merged
merged 4 commits into from
Nov 1, 2023
Merged

fix: some typos in documentation and comments #1433

merged 4 commits into from
Nov 1, 2023

Conversation

nabondance
Copy link
Contributor

@nabondance nabondance commented Nov 1, 2023

Some typos found in the documentation and source code while exploring it

Summary generated by Reviewpad on 01 Nov 23 11:24 UTC

This pull request includes the following changes:

  • In the DeployImpl.ts file, changes are focused on error handling, logging, and package deployment breakdown and printing.
  • The decision record for migrating the sfpowerscripts artifact has been modified in the decision_record.md file.
  • The DeploySourceToOrgImpl.ts file has a modification in a comment related to compatibility with CLI output.
  • The README.md file has updates to improve readability and accuracy.

Let me know if you need more information or assistance.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Nov 1, 2023
Copy link

reviewpad bot commented Nov 1, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@nabondance nabondance changed the title Fixing some typos in documentation and comments Fix: some typos in documentation and comments Nov 1, 2023
@nabondance nabondance changed the title Fix: some typos in documentation and comments fix: some typos in documentation and comments Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab1a369) 46.86% compared to head (d99692a) 46.86%.

❗ Current head d99692a differs from pull request most recent head 64a5021. Consider uploading reports for the commit 64a5021 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      302      313   +11     
=======================================
  Hits         1249     1249           
+ Misses       1414     1386   -28     
- Partials        2       30   +28     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam
Copy link
Contributor

Thanks a lot @nabondance , this really helps

@azlam-abdulsalam azlam-abdulsalam merged commit bd2b216 into dxatscale:main Nov 1, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants